如何少写PHP“烂”代码（二）

PHP 2018-06-19 浏览(2503) 评论(0)

- N +

文章目录 [+]

如何少写PHP“烂”代码（二）第1张如何少写PHP“烂”代码（一）

Action

独立每个操作文件，例如CreateUser,DeleteUser,UpdateUser

符合SOLID的单一原则

UserController

<?php
    namespace App\Http\Controller;

    class UserController extends Controller{

        public $request;
        
        protected $userService;
        
        public function __construct(Request $request, UserService $userService)
        {
            $this->request = $request;
            
            $this->userService = $userService;
        }
        
        public function register(){
            //... validation
            return $this->userService->register($this->request->all());
        }

        public function getUserInfo()
        {
            return $this->userService->getUserInfo ($this->request->all());
        }
    }

UserService

<?php
    namespace App\Service;

    class UserService{
        
        public function getUserInfo(UserRepository $userRepository)
        {
            return $this->userRepository->getUserInfo($data);
        }

        public function register(){
            $result = (new CreateUser())->execute($this->request->all());
            
            return $result;
        }
    }

UserRepository

<?php
    namespace App\Repository;

    class UserRepository{
    
        public function getUserInfo($data)
        {
            $userId = $data['user_id'];
            $result = User::where('id',$userId)->first();
            
            return $result;
        }
    }

CreateUser

<?php

    namespace App\Action;
    
    use App\Model\Member;
    
    class CreateUser extends CreateUserWallet
    {
        public function execute(array $data)
        {
            $models           = new Member();
            $models->tel      = $data['tel'];
            $models->password = $data['password'];
            $result           = $models->save ();
                
            return $result;
        }
    }

以上代码逻辑见下图：